-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSL condition #5724
Support SSL condition #5724
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## development/9.0 #5724 +/- ##
================================================
Coverage 64.92% 64.92%
================================================
Files 185 185
Lines 11663 11668 +5
================================================
+ Hits 7572 7576 +4
- Misses 4091 4092 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
210aa26
to
661b8b2
Compare
661b8b2
to
e90f02e
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/bugfix/CLDSRV-602 && \
git merge origin/development/9.0 Resolve merge conflicts and commit git push origin HEAD:bugfix/CLDSRV-602 |
e90f02e
to
5b24bc2
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
- Bucket policies evaluation is also updated to not compute the request context for each statement, as it will remain the same for a given request anyway. - The isSecure flag is computed every time we need to create request contexts to send to the IAM service. Issue: CLDSRV-602
5b24bc2
to
de8fec1
Compare
/approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-602. Goodbye williamlardier. The following options are set: approve |
Currently, behind a proxy, we cannot detect the right http scheme. Also, we use the request.connection.encrypted variable, that is (1) deprecated and (2) already removed since Node 16, so the whole thing end up being undefined.
Here we call the new function in Arsenal to detect the right scheme, and add it to the request contexts constructor.
We also improve how bucket policies are evaluated: