INTEGRATION [PR#2574 > development/8.7] BB-624 Retry connection to kafka if backbeat processes started before #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing from S3C-9338 because this usage of sdk doesn't use the env variable
Will be improved in S3C-9479
(cherry picked from commit 101af70)
(cherry picked from commit 22282ac)
(cherry picked from commit 3c2aa76)
Prevent hanging indefinitely if replication status' BackbeatConsumer succeeds to connect to kafka but then FailedCRRPRoducer or ReplayProducer fails
If probing too soon on startup some CRR components can crash. Check consumer exists for metric function to use it. Also the probe server is started after the queue (like in ZENKO)
If destination is down on start, QueueProcessor would ignore and start connecting to consumer. Now if destination is down the process will stop and restart so it can try connecting again to destination.
…/bugfix/BB-624-connection-retry
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 3 files with indirect coverage changes
@@ Coverage Diff @@
## development/8.7 #2585 +/- ##
===================================================
+ Coverage 70.31% 70.35% +0.03%
===================================================
Files 194 194
Lines 12997 12997
===================================================
+ Hits 9139 9144 +5
+ Misses 3848 3843 -5
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
…retry' into w/8.5/bugfix/BB-624-connection-retry
BourgoisMickael
force-pushed
the
w/8.7/bugfix/BB-624-connection-retry
branch
from
09f8af4 to
43ae6fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #2574.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.7/bugfix/BB-624-connection-retry, please follow thisprocedure:
$ git fetch $ git checkout w/8.7/bugfix/BB-624-connection-retry $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.7/bugfix/BB-624-connection-retryPlease always comment pull request #2574 instead of this one.