-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB-462 Expiring non-versioned objects fails #2464
Conversation
Hello nicolas2bert,My role is to assist you with the merge of this Status report is not available. |
ping |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/7.70/bugfix/BB-462/lifecycle origin/development/7.70
$ git merge origin/bugfix/BB-462/lifecycle
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/BB-462/lifecycle The following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.5/bugfix/BB-462/lifecycle origin/development/8.5
$ git merge origin/w/7.70/bugfix/BB-462/lifecycle
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.5/bugfix/BB-462/lifecycle The following options are set: create_integration_branches |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "backbeat", | |||
"version": "7.10.13", | |||
"version": "7.10.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the version bump in a separate commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Note: Only buckets with versioning enabled can be configured for replication. To expire non-versioned objects correctly, we currently rely on the InvalidBucketState error returned when the S3C Backbeat API is used for a non-versioned bucket's object, until CLDSRV-461 is implemented to add support for non-versioned buckets to the Backbeat API.
d8ab9f8
to
55b7a0b
Compare
History mismatchMerge commit #d8ab9f8d1c9631ca08b58de056ac4e31faa5e940 on the integration branch It is likely due to a rebase of the branch Please use the The following options are set: create_integration_branches |
@bert-e reset |
Reset completeI have successfully deleted this pull request's integration branches. The following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/7.70/bugfix/BB-462/lifecycle origin/development/7.70
$ git merge origin/bugfix/BB-462/lifecycle
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/7.70/bugfix/BB-462/lifecycle The following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.5/bugfix/BB-462/lifecycle origin/development/8.5
$ git merge origin/w/7.70/bugfix/BB-462/lifecycle
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.5/bugfix/BB-462/lifecycle The following options are set: create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bert-e approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-462. Goodbye nicolas2bert. |
Note1: The change won't be forward-ported into Artesca branches.
Note2: Only buckets with versioning enabled can be configured for replication.
To expire non-versioned objects correctly, we currently rely on the InvalidBucketState error returned when the S3C Backbeat API is used for a non-versioned bucket's object, until CLDSRV-461 is implemented to add support for non-versioned buckets to the Backbeat API.