-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pagination #4537
base: main
Are you sure you want to change the base?
refactor: pagination #4537
Conversation
🦋 Changeset detectedLatest commit: f446dc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
==========================================
+ Coverage 87.58% 87.71% +0.12%
==========================================
Files 335 337 +2
Lines 12803 12873 +70
Branches 3531 3556 +25
==========================================
+ Hits 11213 11291 +78
+ Misses 1590 1582 -8
Continue to review full report in Codecov by Sentry.
|
e751e39
to
ff111d2
Compare
ff111d2
to
3f5d6ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some issues with your coverage, it seems that you are calling onChange
in the test without using vi.fn()
. I think this is what makes the codecov broken
packages/ui/src/components/Pagination/__stories__/Playground.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/Pagination/__stories__/PerPage.stories.tsx
Outdated
Show resolved
Hide resolved
For pagination with item number per page, the size should be small for |
36a6dc2
to
85f0a9c
Compare
85f0a9c
to
af3f877
Compare
af3f877
to
f446dc4
Compare
Summary
Type
Summarise concisely:
What is expected?
Refactor and enhancement of
<Pagination />
:The following changes where made:
Relevant logs and/or screenshots
PerPage :