fix(core): disable check args exist valid for raw #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Cyvoct <[email protected]>
loicbourgois
suggested changes
Mar 18, 2020
Co-Authored-By: Loïc Bourgois <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
loicbourgois
suggested changes
Mar 18, 2020
Signed-off-by: Patrik Cyvoct <[email protected]>
loicbourgois
suggested changes
Mar 18, 2020
internal/namespaces/autocomplete/testdata/test-autocomplete-bash-level1.stdout.golden
Outdated
Show resolved
Hide resolved
| @@ -71,6 +88,25 @@ func Test_handleUnmarshalErrors(t *testing.T) { | |||
| })) | |||
| } | |||
|
|
|||
| func Test_RawArgs(t *testing.T) { | |||
There was a problem hiding this comment.
shoudn't we have a testcobraRun func that only test cobraRun ?
I find it strnage that we hav to test an entire command.
Shouldn't we only call cobraRun() in the test ?
There was a problem hiding this comment.
we could 😄 I'll fix that
There was a problem hiding this comment.
Though it may be more complicated 🤔
Signed-off-by: Patrik Cyvoct <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Signed-off-by: Patrik Cyvoct [email protected]