Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): use args zone on vpc call #1458

Merged
merged 3 commits into from
Oct 2, 2020
Merged

fix(instance): use args zone on vpc call #1458

merged 3 commits into from
Oct 2, 2020

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Oct 2, 2020

Signed-off-by: Patrik Cyvoct [email protected]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1457

@Sh4d1
fix review
25eb675 
Signed-off-by: Patrik Cyvoct <[email protected]>
QuentinBrosse
QuentinBrosse approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit f3c9441 into scaleway:master Oct 2, 2020
@remyleone remyleone added vpc Virtual Private Cloud (VPC) issues, bugs and feature requests instance Instance issues, bugs and feature requests labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private Nics on server get does not respect zone args
4 participants
@Sh4d1 @jerome-quere @QuentinBrosse @remyleone