Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add support for relative date parsing #1366

Merged
merged 13 commits into from
Sep 11, 2020
Merged

feat(core): add support for relative date parsing #1366

merged 13 commits into from
Sep 11, 2020

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone linked an issue Aug 31, 2020 that may be closed by this pull request
Add support for relative date parsing in args #1186
Closed
@remyleone remyleone marked this pull request as draft August 31, 2020 12:45
@remyleone remyleone marked this pull request as ready for review September 2, 2020 13:40
@remyleone remyleone marked this pull request as draft September 2, 2020 13:41
@remyleone remyleone force-pushed the relative_date_parsing branch from eb0068f to 2789b73 Compare September 2, 2020 17:32
@remyleone remyleone force-pushed the relative_date_parsing branch from 2789b73 to df24609 Compare September 2, 2020 17:34
@remyleone remyleone linked an issue Sep 2, 2020 that may be closed by this pull request
Add a section in help about absolute and relative date #1367
Closed
@remyleone remyleone marked this pull request as ready for review September 3, 2020 09:19
jerome-quere
jerome-quere suggested changes Sep 3, 2020
View reviewed changes
cmd/scw/testdata/test-all-usage-help-date-usage.golden Outdated Show resolved Hide resolved
internal/args/errors.go Show resolved Hide resolved
internal/args/errors.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute requested changes Sep 3, 2020
View reviewed changes
internal/core/testing.go Outdated Show resolved Hide resolved
internal/args/unmarshal_test.go Outdated Show resolved Hide resolved
kindermoumoute
kindermoumoute previously approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere previously approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 134b326 into scaleway:master Sep 11, 2020
@remyleone remyleone deleted the relative_date_parsing branch September 11, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@kindermoumoute kindermoumoute kindermoumoute left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a section in help about absolute and relative date Add support for relative date parsing in args
3 participants
@remyleone @jerome-quere @kindermoumoute