Command to support listing secrets #8
Conversation
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
6351276 to
8abdfa6
Compare
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
8abdfa6 to
bbc7f01
Compare
client/client.go
Outdated
| type GetSecretListConfig struct { | ||
| Environment string `json:"environment"` | ||
| } | ||
| type GetSecretListResponse struct { |
There was a problem hiding this comment.
We could ignore Get prefix https://go.dev/doc/effective_go#Getters
client/gcs_service.go
Outdated
| @@ -23,7 +24,7 @@ type Service struct { | |||
| type gcsStore interface { | |||
| WriteToObject(ctx context.Context, bucketName, fileName string, data []byte) error | |||
| ReadObject(ctx context.Context, bucketName, fileName string) ([]byte, error) | |||
| ListOjbect(ctx context.Context, bucketName, path string) ([]string, error) | |||
| ListObject(ctx context.Context, bucketName, path string) ([]google.SecretObject, error) | |||
There was a problem hiding this comment.
It could be google.Object from google's package perspective (GCS object), it doesn't know anything about secrets. In callers, it could be used for secrets or users or any abstraction.
| @@ -77,13 +78,13 @@ func (s Service) GetOrgPublicKeys(ctx context.Context, env, bucketName, path str | |||
| if pubKey != "" { | |||
| return []string{pubKey}, nil | |||
| } | |||
| resp, err := s.store.ListOjbect(ctx, bucketName, path) | |||
There was a problem hiding this comment.
If it's meant for abstraction/local, keep it private.
Also i don't see any logic handled under GetObjList except just returning error and repeated here as well, why do we need this method?
There was a problem hiding this comment.
The GetObjList is added beause i dont wnat client to directly call store.ListObject
client/monart.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("unable to build Get SecretList request: %w", err) | ||
| } | ||
| result := new(GetSecretListResponse) |
There was a problem hiding this comment.
We should have a response type here and we should be building location here, google/gcs.go should only set the fields as is.
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
5a570f3 to
03b804d
Compare
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
03b804d to
16b46d5
Compare
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
bab75ea to
394ac1a
Compare
shubhamvernekar
force-pushed
the
listing-secrets
branch
from
394ac1a to
636edc8
Compare
|
listing all the secrets in cloud and show in tabuler commandline output.