Persisting Application Credentials file location in dolores.json #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shubhamvernekar Once we've stored the application credentials, we should be loading the credentials file while doing operations like encrypt, decrypt, edit, etc. 
In the screenshot the operations are failing. Once we do the changes, the above operations shouldn't fail. |
2 tasks
devdinu
approved these changes
Nov 4, 2023
| } | ||
|
|
||
| if location := md.Location; location != "" { |
There was a problem hiding this comment.
This is sortof optional, It's better to refactor or change code not relevant to the issue/story in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist Application Credential File location in dolores.json and using it from there.