This repository has been archived by the owner on May 27, 2020. It is now read-only.
Split Harness into Test and Section, add testOnly #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 92.15% 95.57% +3.42%
==========================================
Files 17 17
Lines 586 588 +2
Branches 24 23 -1
==========================================
+ Hits 540 562 +22
+ Misses 46 26 -20
Continue to review full report at Codecov.
|
hrhino
approved these changes
Sep 30, 2018
| @@ -38,7 +46,7 @@ sealed abstract class Result | |||
|
|
|||
| final class Fail private() extends Result { | |||
| override val toString: String = "Fail" | |||
| override def equals(other: Any): Boolean = other.asInstanceOf[AnyRef] eq this | |||
| override def equals(other: Any): Boolean = other.isInstanceOf[Fail] | |||
There was a problem hiding this comment.
It's more portable from what I can tell.
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.