Add ability to customize working directory of forked process #83
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mykola.hryhoriev.
|
GrigorievNick
force-pushed
the
add-custom-wroking-dir
branch
from
8ba26ca to
21e2aac
Compare
|
Hi @GrigorievNick, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
@cla-bot[bot] check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Who can review this? |
|
@GrigorievNick Tnx for the contribution. Sorry for the delay in reviewing. I've assigned it to Chee Seng so he'll look at it soon. |
GrigorievNick
force-pushed
the
add-custom-wroking-dir
branch
from
1b54d8b to
593d20e
Compare
pom.xml
Outdated
| <snapshotRepository> | ||
| <id>snapshots</id> | ||
| <name>AppsFlyer Artifactory-snapshots</name> | ||
| <url>https://artifactory.appsflyer.com/artifactory/maven-snapshots/</url> |
There was a problem hiding this comment.
@GrigorievNick Just curious, do we need any artifact from snapshots?
There was a problem hiding this comment.
@cheeseng I am sorry I just deploy this to my own artifactory.
and accidentally commit custom pom details.
pom.xml
Outdated
| @@ -215,6 +228,9 @@ | |||
| <execution> | |||
| <id>sign-artifacts</id> | |||
| <phase>verify</phase> | |||
| <configuration> | |||
| <skip>true</skip> | |||
There was a problem hiding this comment.
@GrigorievNick Do you mind to enlighten us why you need to set the skip to true?
There was a problem hiding this comment.
@cheeseng I am sorry I just deploy this to my own artifactory.
and accidentally commit custom pom details.
GrigorievNick
force-pushed
the
add-custom-wroking-dir
branch
from
593d20e to
6b0c06a
Compare
|
Any news on it, I don't want to keep my custom fork in Company's corporate repo for too long. |
|
@GrigorievNick I am really sorry for getting back here so late, hopefully this round we'll get this in! |
No description provided.