Use same JVM that maven is using.

[cstroe]

Use the java executable that Maven ran with. Inspired from the Surefire plugin's getEffectiveJvm minus the toolchain lookup.

Fixes #6, #14 and #26

[cstroe]

@gcberger I'd love to have this be included in the upcoming version 2.0.0!

[cstroe]

@gcberger Any chance in merging this?

[robsonpeixoto]

@gcberger ping

[andrewdibiasio6]

I echo this @gcberger "Any chance in merging this?"

[gcberger]

Hi Bill - Forwarding this, in case you don't get these. George

…

On Wed, Oct 4, 2017 at 10:15 AM, andrewdibiasio6 - ***@***.*** ***@***.***> wrote: I echo this @gcberger <https://github.com/gcberger> "Any chance in merging this?" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD52beyKYbEIbDqdkHwjt_yddLDvfYU1ks5so71AgaJpZM4Nl8y-> .

[Mats-SX]

Ping. We'd love to have this.

[martin-g]

I think a better solution would be to make scalatest-maven-plugin toolchains aware (#58). I don't think this PR would solve the issue described at #58 .

[cstroe]

I think the delay is that I have to sign the CLA, which has to be approved by my current employer: #37 (comment)

Also, yes, we should definitely make this plugin Toolchain aware, but that could be subsequent work.

[martin-g]

I can do the work to use ToolchainManager in the coming days if there is a chance that it will be ever used. This PR is one year and a half old and it seems there is no much interest from the maintainers.

[cstroe]

Some options to solve maintainership absence:

1. The current maintainers can add an active member of the OSS community as a committer/maintainer to this repository and have them be the approver of commits.
2. The community can fork this repo into another org that can be better maintained.
3. Something else I couldn't think of...?

I think the first option is better as it avoids fragmentation of the community.

[cstroe]

@gcberger @bvenners , I have signed and emailed the CLA.

[bvenners]

@cstroe Thanks very much! I got the CLA. We'll get this merged and released as soon as we can.

[stefano-xy]

@bvenners , are the administrative problems solved? I would also like to have this merged. Thanks.

[manuzhang]

Any progress here ?

[bvenners]

Sorry for the delay. I'll get it going.

[rondefreitas]

Thanks @bvenners . Looking forward to seeing this out there. There's a couple of other PRs I've been waiting on seeing merged (and I'm sure others). No pressure though and thanks for circling back to look at this project :)

[manuzhang]

@bvenners @katrinsharp Thanks, is there a plan to make a new release with this fix ?

[katrinsharp]

@manuzhang I'll discuss with @bvenners and let you know. Please stay tuned.

[manuzhang]

@katrinsharp @bvenners Thanks. Any plan to make a new release for this fix ?

[katrinsharp]

@manuzhang my bad I'm slow on some other open PRs to review. I'll try to fit all open ones in next couple of weeks.

[chetanmeh]

@katrinsharp Any plan to make a new release for this fix ?

[katrinsharp]

@chetanmeh My apologies! I'm going to handle this as we speak.

[chetanmeh]

Thanks @katrinsharp for responding and looking into this

[katrinsharp]

Update: I'm handling couple of different PRs and then release - several days.

[amirhadadi]

@katrinsharp can you please release a version with this fix?

[qsarahd]

Joining the requests. @katrinsharp, can you please release a version with the fix?

[katrinsharp]

It was released. There is an issue to sync up with Maven central - I've put a request to get it sorted, meanwhile you can try the new version by adding this to your PM:

<pluginRepositories>
  <pluginRepository>
    <id>releases</id>
    <url>https://repo1.maven.org/maven2</url>
  </pluginRepository>
</pluginRepositories>

I'll add a new comment here letting everyone know that it was synced up with Maven central.

Update: you don't need to add thew above code, the jar did make its way into maven central, it is just https://mvnrepository.com/artifact/org.scalatest/scalatest-maven-plugin doesn't reflect that. I'm on it.

And it is on Maven central now.