Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify AWS and Azure database setup–related labels in sidebar navigation #845

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

josh-wong
Copy link
Member

Description

This PR clarifies the AWS and Azure database setup–related labels in the sidebar navigation. Since we made a similar change recently on the ScalarDL docs site for the same docs, we should be consistent with using the same labels in the ScalarDB sidebar navigation.

Related issues and/or PRs

Changes made

  • Changed the generic mention of AWS and Azure under the Database Setup Guides sub-category with Databases on AWS and Databases on AWS, respectively, in the sidebar navigation for versions 3.14 (latest), 3.13, and 3.12 for both English and Japanese.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@josh-wong josh-wong added the sidebar navigation Updates to the sidebar navigation label Jan 16, 2025
@josh-wong josh-wong self-assigned this Jan 16, 2025
@josh-wong josh-wong merged commit 4b92591 into main Jan 16, 2025
1 check passed
@josh-wong josh-wong deleted the revise-deployment-sidebar-labels branch January 16, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sidebar navigation Updates to the sidebar navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant