Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pretty printer: backquote importees when needed #2260

Merged
merged 1 commit into from
Mar 1, 2021
Merged

pretty printer: backquote importees when needed #2260

merged 1 commit into from
Mar 1, 2021

Conversation

bjaglin
Copy link
Member

@bjaglin bjaglin commented Feb 28, 2021 •
edited
Loading

Originally reported as scalacenter/scalafix#1337.
Fix regression introduced in #2239.

@bjaglin bjaglin mentioned this pull request Feb 28, 2021
Closed
@bjaglin bjaglin marked this pull request as ready for review February 28, 2021 22:10
olafurpg
olafurpg approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for fixing this!

@olafurpg olafurpg requested a review from tgodzik March 1, 2021 09:56
@kpbochenek
Copy link
Collaborator

Is this testcase correct? assert(q"import a.`{ q }`".syntax == "import a.`{ q }`")
Shouldn't it be a.{`q`} ?

@bjaglin
Copy link
Member Author

bjaglin commented Mar 1, 2021 •
edited
Loading

Is this testcase correct? assert(q"import a.`{ q }`".syntax == "import a.`{ q }`")
Shouldn't it be a.{`q`} ?

From my understanding, `{ q }` is a correct (although nasty!) identifier: liancheng/scalafix-organize-imports@c7bb8d2

tgodzik
tgodzik approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM!

@tgodzik tgodzik merged commit c7d214f into scalameta:master Mar 1, 2021
@tgodzik tgodzik mentioned this pull request Mar 30, 2021
Closed
@liancheng liancheng mentioned this pull request Apr 9, 2021
Merged
@liancheng liancheng mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjaglin @kpbochenek @olafurpg @tgodzik @github-brice-jaglin