improvement: Add flags to release for JDK 8 #4719
Conversation
tgodzik
force-pushed
the
switch-to-8
branch
2 times, most recently
from
ffe47fe to
a640a8b
Compare
|
I think this should work, I checked and the class files produced are version 52. I just had a weird issue with javadoc, where the target option would be forwarded to it, which makes no sense, since javadoc doesn't support the same options. I just set the options for it to nil |
tgodzik
force-pushed
the
switch-to-8
branch
4 times, most recently
from
26db844 to
84fc5a7
Compare
|
I think we should be good now. |
| @@ -58,9 +58,9 @@ object TestHelpers { | |||
| val out1 = x1.formattedCode | |||
| val lines2 = x1.formattedCode.count(_ == '\n') | |||
| val (duration2, result2) = formatCode(out1) | |||
| def saveFormatted(): Unit = Files.writeString( | |||
| def saveFormatted(): Unit = Files.write( | |||
There was a problem hiding this comment.
This method and the one below was added in JDK 11, but wasn't an issue for released artifacts since it's in the tests only
There was a problem hiding this comment.
should we instead add new flags to the Compile / so it doesn't affect Test?
There was a problem hiding this comment.
I mean, maybe it's better to be consistent here? And the changes are quite small.
build.sbt
Outdated
| "-target:8", | ||
| "-release:8", | ||
| ) | ||
| case _ => Seq("-target:8", "-release:8") |
There was a problem hiding this comment.
rather than adding these twice, to each scala version, should we follow the example of unused below and append separately?
There was a problem hiding this comment.
sure, done. I at some point I thought those might differ
| @@ -58,9 +58,9 @@ object TestHelpers { | |||
| val out1 = x1.formattedCode | |||
| val lines2 = x1.formattedCode.count(_ == '\n') | |||
| val (duration2, result2) = formatCode(out1) | |||
| def saveFormatted(): Unit = Files.writeString( | |||
| def saveFormatted(): Unit = Files.write( | |||
There was a problem hiding this comment.
should we instead add new flags to the Compile / so it doesn't affect Test?
| ).jvmSettings(crossVersion := CrossVersion.disabled, autoScalaLibrary := false) | ||
| ).jvmSettings( | ||
| javacOptions ++= Seq("-source", "8", "-target", "8"), | ||
| Compile / doc / javacOptions := Seq(), |
There was a problem hiding this comment.
are you sure you still need this for doc? especially if you used the one above with Compile /?
There was a problem hiding this comment.
yeah, it still didn't work without it
No description provided.