Split: switch ignoreIf to tag, allows more control #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poslegm
reviewed
Feb 24, 2020
|
|
||
| object SplitTag extends Enumeration { |
There was a problem hiding this comment.
My only issue is a scala.Enumeration usage
sealed trait SplitTag
object SplitTag {
case object Ignored extends SplitTag
case object Active extends SplitTag
}sealed hierarchies is a little bit verbose, but a simple and reliable syntax.
There was a problem hiding this comment.
will do, thank you.
Rather than enabling a split using a simple boolean flag, let's allow a split to be enabled in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than enabling a split using a simple boolean flag, let's allow a split to be enabled in some cases. This will allow us to set up some splits which will not be used unless some policy in a specific context decided to use them (for instance, splits for ", {" that would be triggered only if
OneArgPerLinepolicy is used). See #1722, will be used in that PR.Also, make a few minor cosmetic changes.