Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanup and refactoring changes in BestFirstSearch #1728

Merged
merged 10 commits into from
Feb 21, 2020

Conversation

kitbellew
Copy link
Collaborator

Removes some unused code or unnecessary complexity. Doesn't change formatting.

Precursor to the algorithm fix which addresses a host of "unable to format due to bug in scalafmt" issues, to be submitted after.

@kitbellew
Copy link
Collaborator Author

@olafurpg @tanishiking @poslegm PTAL

Copy link
Collaborator

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with it, but I think that @olafurpg has more expertise in this part of code

@kitbellew kitbellew merged commit 09c589e into scalameta:master Feb 21, 2020
@kitbellew kitbellew deleted the 1728 branch February 21, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants