Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatWriter: {} => (): don't rewrite some lambdas #1709

Merged
merged 3 commits into from
Feb 16, 2020

Conversation

kitbellew
Copy link
Collaborator

@kitbellew kitbellew commented Feb 15, 2020

We can't rewrite a lambda unless it has parens around parameters or one simple parameter without a type.

Fixes #1707.
Fixes #1708.

@kitbellew
Copy link
Collaborator Author

@olafurpg @tanishiking @poslegm PTAL, bugfix in 2.4.0.

We can't rewrite a lambda unless it has parens around parameters or one
simple parameter without a type.

Fixes scalameta#1707.
Fixes scalameta#1708.
Copy link
Collaborator

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for hotfix!

@kitbellew kitbellew merged commit 6caa1ee into scalameta:master Feb 16, 2020
@kitbellew kitbellew deleted the 1707 branch February 16, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4.0: scalafmtAll failing to run on code that compiles New version 2.4.0 breaks some code
2 participants