-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate uploading native images to release notes #1711
Comments
@olafurpg @tanishiking @poslegm if one of you understands about release-drafter (which might be related to this problem), that component is acting up; it has stopped drafting releases, i wrote them manually. |
The release drafter service has been discontinued in favor of a custom GitHub action that we haven’t setup in the Scalafmt repo (example https://github.com/scalameta/metals-languageclient/blob/master/.github/workflows/release-drafter.yml). As for the native image, I have manually uploaded those binaries for releases so far under the assumption that Scalafmt releases are infrequent. there’s been a lot activity lately so it might be worth automating the native image uploading, but to fix this issue it’s probably best to manually download the binaries from the GitHub actions web ui and upload them in the GitHub releases ui. The tricky part with automating the uploading is that we normally wait with creating a release until the artifacts are available on maven central. Maybe we can somehow run the action on the “release” event 🤔 |
Steps
I tried to install native image according to docs:
I took a look at GH release and it makes sense as the only artifacts included to release are source packages. After some digging I found that artifacts are available here: https://github.com/scalameta/scalafmt/actions/runs/39759768
I know literally nothing about Github Actions but I believe it might be worth trying to modify native.yml so it uses https://github.com/actions/upload-release-asset.
upload-release-asset
hasupload_url
as an input and https://github.com/release-drafter/release-drafter has it as output.I may take a look at this in following days. I am assuming github actions are runnable on forks as say travis-ci.
The text was updated successfully, but these errors were encountered: