AvoidInfix: fix isWrapped, look for external paren

scalameta · May 31, 2022 · dd63d5d · dd63d5d
1 parent 850e98e
commit dd63d5d
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 13 deletions.
diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/AvoidInfix.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/AvoidInfix.scala
@@ -45,7 +45,7 @@ class AvoidInfix(implicit ctx: RewriteCtx) extends RewriteSession {
         builder += TokenPatch.AddLeft(opHead, ".", keepTok = true)
 
         val opLast = op.tokens.last
-        val opNextOpt = ctx.tokenTraverser.nextNonTrivialToken(opLast)
+        val opNextOpt = nextNonTrivial(opLast)
 
         def moveOpenDelim(prev: Token, open: Token): Unit = {
           // move delimiter (before comment or newline)
@@ -65,7 +65,7 @@ class AvoidInfix(implicit ctx: RewriteCtx) extends RewriteSession {
               rb <- ctx.getMatchingOpt(lb)
               rbNext <- {
                 moveOpenDelim(opLast, lb)
-                ctx.tokenTraverser.nextNonTrivialToken(rb)
+                nextNonTrivial(rb)
               }
             } yield (rb, rbNext)
         // move the left paren if enclosed, else enclose
@@ -129,9 +129,21 @@ class AvoidInfix(implicit ctx: RewriteCtx) extends RewriteSession {
     })
   }
 
-  private def isWrapped(t: Tree): Boolean = t.tokens.head match {
-    case h: Token.LeftParen => ctx.getMatchingOpt(h).contains(t.tokens.last)
-    case _ => false
+  private def isWrapped(t: Tree): Boolean = {
+    val head = t.tokens.head
+    val last = t.tokens.last
+    isMatching(head, last) ||
+    ctx.tokenTraverser.prevNonTrivialToken(head).exists {
+      isMatching(_, nextNonTrivial(last).orNull)
+    }
   }
 
+  @inline
+  private def isMatching(head: Token, last: => Token): Boolean =
+    head.is[Token.LeftParen] && ctx.isMatching(head, last)
+
+  @inline
+  private def nextNonTrivial(token: Token): Option[Token] =
+    ctx.tokenTraverser.nextNonTrivialToken(token)
+
 }
diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/Rewrite.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/Rewrite.scala
@@ -31,8 +31,8 @@ case class RewriteCtx(
   @inline def getMatchingOpt(a: Token): Option[Token] =
     matchingParens.get(TokenOps.hash(a))
 
-  @inline def isMatching(a: Token, b: Token) =
-    getMatchingOpt(a).contains(b)
+  @inline def isMatching(a: Token, b: => Token) =
+    getMatchingOpt(a).exists(_ eq b)
 
   @inline def getIndex(token: Token) = tokenTraverser.getIndex(token)
 

diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/util/TokenTraverser.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/util/TokenTraverser.scala
@@ -49,16 +49,19 @@ class TokenTraverser(tokens: Tokens, input: Input) {
     }
   }
 
-  def nextNonTrivialToken(token: Token): Option[Token] =
-    findAfter(token)(x => if (x.is[Trivia]) None else Some(true))
-
   def prevToken(token: Token): Token = {
     tok2idx.get(token) match {
       case Some(i) if i > 0 => tokens(i - 1)
       case _ => token
     }
   }
 
+  def nextNonTrivialToken(token: Token): Option[Token] =
+    findAfter(token)(TokenTraverser.isTrivialPred)
+
+  def prevNonTrivialToken(token: Token): Option[Token] =
+    findBefore(token)(TokenTraverser.isTrivialPred)
+
   /** Find a token after the given one. The search stops when the predicate
     * returns Some value (or the end is reached).
     * @return
@@ -119,3 +122,10 @@ class TokenTraverser(tokens: Tokens, input: Input) {
   }
 
 }
+
+object TokenTraverser {
+
+  private def isTrivialPred(token: Token): Option[Boolean] =
+    if (token.is[Trivia]) None else Some(true)
+
+}
diff --git a/scalafmt-tests/src/test/resources/rewrite/AvoidInfix.stat b/scalafmt-tests/src/test/resources/rewrite/AvoidInfix.stat
@@ -399,14 +399,14 @@ rewrite.neverInfix.includeFilters = [ "[^*]+" ]
 ===
 1 foo (2 +: 3) / 4
 >>>
-1.foo(((2 +: 3))./(4))
+1.foo((2 +: 3)./(4))
 <<< avoid double wrap 2
 rewrite.neverInfix.includeFilters = [ "[^*]+" ]
 ===
 1 foo ((2) +: 3) / 4
 >>>
-1.foo((((2) +: 3))./(4))
+1.foo(((2) +: 3)./(4))
 <<< rewrite wrapped placeholder
 foo baz (_)
 >>>
-foo baz (_)
+foo.baz(_)