Implement error method with an additinal error message and cause #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step to tackle this issue: scalameta/scalafmt#1628
Without this implementation, the reporter ends up discarding the error information of the
cause
ofdefault void error(Path file, String message, Throwable e)
.For example, the original cause of CorruptedClassPath is discarded, and currently, we have no clue to tackle this kind of problem: scalameta/scalafmt#1628
Because
default void error(Path file, String message, Throwable e)
is something like this: wrapping the additional message withRuntimeException
and put the original exception to thecause
of theRuntimeException
cause
if there's a message:sbt-scalafmt/plugin/src/main/scala/org/scalafmt/sbt/ScalafmtSbtReporter.scala
Lines 19 to 25 in ed2efe2
So this PR enables SbtScalafmtReporter to show the original error message passed via the third argument of
default void error(Path file, String message, Throwable e)
.