Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error method with an additinal error message and cause #78

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

tanishiking
Copy link
Member

@tanishiking tanishiking commented Jan 16, 2020

The first step to tackle this issue: scalameta/scalafmt#1628

Without this implementation, the reporter ends up discarding the error information of the cause of default void error(Path file, String message, Throwable e).
For example, the original cause of CorruptedClassPath is discarded, and currently, we have no clue to tackle this kind of problem: scalameta/scalafmt#1628

Because


So this PR enables SbtScalafmtReporter to show the original error message passed via the third argument of default void error(Path file, String message, Throwable e).

@tanishiking
Copy link
Member Author

Thank you for reviewing! I'm gonna cut a new release today.

@tanishiking tanishiking merged commit 09f9fa1 into scalameta:master Jan 18, 2020
@tanishiking tanishiking deleted the show-error-corrupt branch January 18, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants