Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing configured repositories to scalafmt instance #73

Merged
merged 2 commits into from
Dec 9, 2019
Merged

passing configured repositories to scalafmt instance #73

merged 2 commits into from
Dec 9, 2019

Conversation

slivkamiro
Copy link
Contributor

This change is related to scalafmt issue scalameta/scalafmt#1521
Related pull request is still in review scalameta/scalafmt#1586

@slivkamiro slivkamiro mentioned this pull request Dec 6, 2019
Merged
@poslegm
Copy link
Collaborator

poslegm commented Dec 6, 2019

LGTM, we can merge it after scalafmt-core release 👍

tanishiking
tanishiking approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍 Thank you so much for your series of contributions!

@poslegm poslegm merged commit eb4f4b0 into scalameta:master Dec 9, 2019
@poslegm
Copy link
Collaborator

poslegm commented Dec 9, 2019

I pushed v2.3.0 tag. Waiting for Maven Central updates. Thank you for you contribution again!

@sideeffffect
Copy link

I've just tried 2.3.0, and it doesn't seem to work as intended, sbt.repository.config and sbt.override.build.repos is probably no honored, and so the build behind corporate firewall fails:

[13:02:00] [Step 1/5] [info] Checking 2 Scala sources...
[13:14:44] [Step 1/5] [error] failed to resolve Scalafmt version '2.3.0': /workdir/.scalafmt.conf
[13:14:44] [Step 1/5] [error] (Compile / scalafmtSbtCheck) failed to resolve Scalafmt version '2.3.0': /workdir/.scalafmt.conf
[13:14:44] [Step 1/5] [error] Total time: 765 s (12:45), completed Dec 13, 2019, 12:14:29 PM
[13:14:45] [Step 1/5] Total time: 776404 ms

so #62 should remain open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanishiking tanishiking tanishiking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slivkamiro @poslegm @sideeffffect @tanishiking