Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic findTextInDependencyJars implemented. #247

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Oct 8, 2021

This is needed for the functionality added in
scalameta/metals#3093.

This is needed for the functionality added in
scalameta/metals#3093.
@ckipp01 ckipp01 marked this pull request as ready for review October 8, 2021 14:55
@ckipp01
Copy link
Member Author

ckipp01 commented Oct 8, 2021

For now I just stole the logic from neovim/neovim#15960, however if that gets merged we should be able to just use the logic straight from core.

@ckipp01 ckipp01 merged commit 1154c39 into scalameta:main Oct 8, 2021
@ckipp01 ckipp01 deleted the find-in-jar branch October 8, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant