Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Scala3 to 3.3.1 #733

Closed
wants to merge 1 commit into from
Closed

Upgrade Scala3 to 3.3.1 #733

wants to merge 1 commit into from

Conversation

valencik
Copy link
Collaborator

No description provided.

@valencik valencik self-assigned this Jan 12, 2024
@SethTisue
Copy link
Contributor

looks like overly sensitive test expectations that just need adjusting?

@valencik
Copy link
Collaborator Author

It looks like the Compare helper isn't working on Scala 3.3.1.

For the assertion

assertEquals('a', 'a'.toInt)

We used to have something like:

error:
Can't compare these two types:
  First type:  Char
  Second type: Int
Possible ways to fix this error:
  Alternative 1: provide an implicit instance for Compare[Char, Int]
  Alternative 2: upcast either type into `Any` or a shared supertype.

Followed by some additional text about implicits if on Scala 3.1.

But now we have just:

error: missing argument for parameter compare of method assertEquals in trait Assertions: (implicit loc: munit.Location, compare: munit.Compare[Char, Int]): Unit

Which seems like a regression.
I think we want to actually try and restore the old behaviour.

@tgodzik
Copy link
Contributor

tgodzik commented Apr 18, 2024

Already updated in main

@tgodzik tgodzik closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants