-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scalanative.runtime.loop()
invocation to correct place
#700
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
munit/native/src/main/scala/munit/internal/junitinterface/JUnitTask.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Adapted from https://github.com/scala-js/scala-js, see NOTICE.md. | ||
*/ | ||
|
||
package munit.internal.junitinterface | ||
|
||
import munit.internal.PlatformCompat | ||
import org.junit.runner.notification.RunNotifier | ||
import sbt.testing._ | ||
import scala.concurrent.ExecutionContext.Implicits.global | ||
|
||
/* Implementation note: In JUnitTask we use Future[Try[Unit]] instead of simply | ||
* Future[Unit]. This is to prevent Scala's Future implementation to box/wrap | ||
* fatal errors (most importantly AssertionError) in ExecutionExceptions. We | ||
* need to prevent the wrapping in order to hide the fact that we use async | ||
* under the hood and stay consistent with JVM JUnit. | ||
*/ | ||
final class JUnitTask( | ||
_taskDef: TaskDef, | ||
runSettings: RunSettings, | ||
classLoader: ClassLoader | ||
) extends Task { | ||
|
||
override def taskDef(): TaskDef = _taskDef | ||
override def tags(): Array[String] = Array.empty | ||
|
||
def execute( | ||
eventHandler: EventHandler, | ||
loggers: Array[Logger] | ||
): Array[Task] = { | ||
PlatformCompat.newRunner(taskDef(), classLoader) match { | ||
case None => | ||
case Some(runner) => | ||
runner.filter(runSettings.tags) | ||
val reporter = | ||
new JUnitReporter(eventHandler, loggers, runSettings, taskDef()) | ||
val notifier: RunNotifier = new MUnitRunNotifier(reporter) | ||
runner.run(notifier) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. JS uses |
||
} | ||
Array() | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package munit | ||
|
||
import scala.concurrent._ | ||
|
||
class Issue695Suite extends FunSuite { | ||
override def munitExecutionContext = ExecutionContext.global | ||
|
||
test("await task on global EC") { | ||
val p = Promise[Unit]() | ||
ExecutionContext.global.execute { () => | ||
Thread.sleep(1000) | ||
p.success(()) | ||
} | ||
p.future | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how specs2 is working as well.
https://github.com/etorreborre/specs2/blob/b4fb0a16f1a0369fe69eb994220317a5aaf2f3d9/common/native/src/main/scala/org/specs2/concurrent/package.scala#L8-L11