More correct string inequality error message #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic may claim values have the same `toString()` when they don't. The 'full' solution would of course be to have a 'strict' string diff, but until then let's at least not lie about it. Fixes scalameta#152
olafurpg
approved these changes
Oct 5, 2021
|
Just getting (re-)acquainted with munit today, and I needed this fix so bad. My expected was missing a trailing newline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic may claim values have the same
toString()when they don't. The 'full' solution would of course be to
have a 'strict' string diff, but until then let's at least
not lie about it.
Fixes #152