Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add package objects when creating package.scala file #866

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Automatically add package objects when creating package.scala file #866

merged 1 commit into from
Aug 14, 2019

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Aug 13, 2019

No description provided.

@tgodzik tgodzik requested a review from mzarnowski August 13, 2019 19:57
gabro
gabro requested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool feature :)

I've left a couple of comments/suggestions

metals/src/main/scala/scala/meta/internal/metals/PackageProvider.scala Outdated Show resolved Hide resolved
metals/src/main/scala/scala/meta/internal/metals/PackageProvider.scala Outdated Show resolved Hide resolved
metals/src/main/scala/scala/meta/internal/metals/PackageProvider.scala Outdated Show resolved Hide resolved
mzarnowski
mzarnowski approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@mzarnowski mzarnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add over what @gabro has mentioned.

@tgodzik tgodzik force-pushed the add-package-object branch from 0a16d46 to 22ddb41 Compare August 14, 2019 11:10
gabro
gabro approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tgodzik tgodzik merged commit 656ed8c into scalameta:master Aug 14, 2019
@tgodzik tgodzik deleted the add-package-object branch August 14, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzarnowski mzarnowski mzarnowski approved these changes

@gabro gabro gabro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodzik @gabro @mzarnowski