Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: sort abstract members for auto implement #6496

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

kasiaMarek
Copy link
Contributor

No description provided.

@kasiaMarek kasiaMarek force-pushed the sort-abstract-memebers branch from bdffc9f to 25fb423 Compare June 12, 2024 11:10
sym1.sourcePos.start <= sym2.sourcePos.start
else !sym2.sourcePos.exists
})
}.toSeq.sortBy(_._1.name.decoded).flatMap(_._2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted the parent classes by name for sake of stabilising the tests.

@kasiaMarek kasiaMarek force-pushed the sort-abstract-memebers branch from 25fb423 to a13edd4 Compare June 12, 2024 12:04
@kasiaMarek kasiaMarek requested a review from tgodzik June 12, 2024 13:52
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiaMarek kasiaMarek merged commit 121c584 into scalameta:main Jun 12, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants