improvement: Match completions on union types #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Feb 16, 2024
| |""".stripMargin, | ||
| compat = Map( | ||
| "3" -> """|match | ||
| |match (exhaustive) Option (2 cases) |
There was a problem hiding this comment.
We might need to adjust the results for nightly Scala version.
There was a problem hiding this comment.
I've ignored the tests for now, until we backport to Dotty.
tgodzik
requested changes
Feb 16, 2024
Exhaustive match completion now works on union of case classes. Also improves the labels for match completion.
jkciesluk
force-pushed
the
remove-parents
branch
from
659e1d7 to
c508904
Compare
kasiaMarek
added a commit
to scala/scala3
that referenced
this pull request
Feb 28, 2024
WojciechMazur
added a commit
to scala/scala3
that referenced
this pull request
Jul 2, 2024
scalameta/metals#6074 scalameta/metals#6129 [Cherry-picked 4742d7d][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes scalameta/metals-feature-requests#371