Single file support WIP #5531
Closed
Single file support WIP #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Oct 10, 2023
| @@ -153,6 +154,29 @@ class WorkspaceLspService( | |||
| languageClient, | |||
| ) | |||
|
|
|||
| val fallbackService: FallbackMetalsLspService = { | |||
There was a problem hiding this comment.
Maybe we could create it lazily?
| buildTargets: BuildTargets, | ||
| )(implicit ec: ExecutionContextExecutorService) | ||
| extends Cancelable { | ||
| val buildTargetsData = new TargetData |
kasiaMarek
force-pushed
the
single-file-support
branch
from
0267afd to
d0f78cc
Compare
kasiaMarek
force-pushed
the
single-file-support
branch
3 times, most recently
from
bdb9373 to
bd2697f
Compare
kasiaMarek
force-pushed
the
single-file-support
branch
2 times, most recently
from
7600a7e to
6dfe0ed
Compare
kasiaMarek
force-pushed
the
single-file-support
branch
from
6dfe0ed to
43c690c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fast solution to add single file support.
resolves: scalameta/metals-feature-requests#231
TODO:
scala-cliserversMetalsLspServerso it doesn't need a main connection