Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add special case for autoimport inside Import tree #4555

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

dos65
Copy link
Member

@dos65 dos65 commented Oct 21, 2022

Previously, the behaviour for auto-import action wasn't specified for
import <<$SYMBOL>> case.
Now in imports the required symbol using specifying full name in case if it's missing in scope as we do that in completions

@dos65 dos65 changed the title fix: scala2 - infer autoimport pos correctly for non package level fix: scala2 - infer autoimport pos correctly for non package level import statements Oct 21, 2022
@dos65 dos65 force-pushed the scala2_autoimport_pos_fix branch from cb5ebbc to ce72cc5 Compare October 21, 2022 10:48
Previously, the behaviour for auto-import action wasn't specified for
`import <<$SYMBOL>>` case.
Now in imports the required symbol using specifying full name in case if it's missing in scope as we do that in completions
@dos65 dos65 force-pushed the scala2_autoimport_pos_fix branch from ce72cc5 to aea2813 Compare October 23, 2022 20:29
@dos65 dos65 changed the title fix: scala2 - infer autoimport pos correctly for non package level import statements fix: add special case for autoimport inside Import tree Oct 23, 2022
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dos65 dos65 merged commit adadc11 into scalameta:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants