Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable organize imports for Scala 3 #2857

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 5, 2021

Since 0.9.29 it's possible to use most of the existing rules on Scala 3 including organize-imports. This still have 2 caveats:

  • unused imports will not be removed since we don't get that information from the compiler
  • we will need to run 2.13 scalafix for Scala 3 sources until Scalafix is released for Scala 3. This is only a problem for ExplicitResultTypes, which anyway wouldn't work in Metals.

Fixes #2856

Since 0.9.29 it's possible to use most of the existing rules on Scala 3 including organize-imports. This still have 2 caveats:
- unused imports will not be removed since we don't get that information from the compiler
- we will need to run 2.13 scalafix for Scala 3 sources until Scalafix is released for Scala 3. This is only a problem for ExplicitResultTypes, which anyway wouldn't work in Metals.
Copy link
Member

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tgodzik tgodzik merged commit d3aa263 into scalameta:main Jun 5, 2021
@tgodzik tgodzik deleted the scala3-organize-imports branch June 5, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalafix support for Scala 3
2 participants