Add support for Scala 3 3.0.0-M2 #2260
Conversation
| @@ -214,7 +214,7 @@ lazy val V = new { | |||
| def scala2Versions = nonDeprecatedScala2Versions ++ deprecatedScala2Versions | |||
|
|
|||
| // Scala 3 | |||
| def nonDeprecatedScala3Versions = Seq(scala3, "0.27.0-RC1") | |||
| def nonDeprecatedScala3Versions = Seq(scala3, "3.0.0-M1", "0.27.0-RC1") | |||
There was a problem hiding this comment.
Just because I don't fully remember where we ended up on this. How long will we keep 0.27.0-RC1 around as non-deprecated?
There was a problem hiding this comment.
Probably under the end of the course at EPFL.
| if (scalaVersion == "0.27.0-RC1") "2.2.10" | ||
| else if (scalaVersion == "3.0.0-M1") "2.2.12" | ||
| else BuildInfo.mdocVersion |
There was a problem hiding this comment.
I honestly don't love that we are doing this. Was it just not possible to publish mdoc for both M1 and M2? It seems a bit extreme that have to have logic to include 1 of 3 different versions of a single dependency.
There was a problem hiding this comment.
It seemed simpler to just put in the logic here. We need to double the code for each Scala 3 version currently and it's really only Metals doing it. I might have been too quick, but there was no real changes between all those changes that would impact worksheets.
There was a problem hiding this comment.
After the changes in scala/scala3#10172 we should be able to just do scalameta/mdoc@81e43c1
tgodzik
force-pushed
the
add-support-for-3.0.0-M2
branch
from
3d3075e to
bad2ebd
Compare
No description provided.