Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored DefinitionCrossLspSuite test fails in CI but not locally. #3688

Closed
ckipp01 opened this issue Mar 8, 2022 · 0 comments · Fixed by #3692
Closed

Ignored DefinitionCrossLspSuite test fails in CI but not locally. #3688

ckipp01 opened this issue Mar 8, 2022 · 0 comments · Fixed by #3692

Comments

@ckipp01
Copy link
Member

ckipp01 commented Mar 8, 2022

Describe the bug

The underscore test in DefinitionCrossLspSuite fails in CI but not locally.

Expected behavior

I'd expect this to pas.

NOTE: I'll include some more details on this, but just creating this for now to get a ticket number to put in #3631

tgodzik added a commit to tgodzik/metals that referenced this issue Mar 10, 2022
Previously, we were not waiting for the compilation to finish which was causing the semanticdb not to be available. Now we properly use the for comprehension.

Fixes scalameta#3688
tgodzik added a commit to tgodzik/metals that referenced this issue Mar 10, 2022
Previously, we were not waiting for the compilation to finish which was causing the semanticdb not to be available. Now we properly use the for comprehension.

Fixes scalameta#3688
@kpodsiad kpodsiad added this to the Metals v0.11.3 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants