feat: add doctor visibility provider & extract doctor #930
Conversation
src/doctor.ts
Outdated
| this.doctor.onDidDispose(() => { | ||
| this.client.sendNotification(doctorNotification, { visible: false }); | ||
| this.isVisible = false; | ||
| this.doctor = undefined; | ||
| }); |
There was a problem hiding this comment.
There is also an option to change visibility if this tab isn't focused.
this.doctor.onDidChangeViewState(() => {
this.doctor.visible
})There was a problem hiding this comment.
onDidChangeViewState fires when webview isn't focused or stops being visible?
I assumed that if the webview is open then we should always treat it as "visible" - user may come to it anytime and we should display them actual status.
There was a problem hiding this comment.
I assumed that if the webview is open then we should always treat it as "visible" - user may come to it anytime and we should display them actual status.
Haha. Actually, this visible word usage attracted my attention to that and I decided to check if it really about visibility or not.
Won't it be equal to the just opening a doctor page?
I think if we introduce some kind of cache it won't take a lot of time to refresh it after focusing on it back.
|
@kpodsiad There is some issue with build and test. |
needs scalameta/metals-languageclient#439