Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metals.pantsTargets setting #214

Closed
wants to merge 1 commit into from

Conversation

murph
Copy link

@murph murph commented Feb 17, 2020

@olafurpg merged basic support for the Pants build tool for metals in scalameta/metals#935

Part of this support is a new user-configurable setting, metals.pantsTargets.

Here's my attempt at adding that setting to the extension settings UI.

I've never touched a vscode extension before, so more than happy for lots of feedback.

@murph murph requested a review from olafurpg February 17, 2020 20:56
@olafurpg
Copy link
Member

Thank you for this contribution! The pants integration is still evolving and is unsupported at this time. I think it’s best to wait until it’s stable before adding publicly visible configuration options

@murph
Copy link
Author

murph commented Feb 18, 2020

I understand your caution. Maybe if I added some text indicating that it's experimental and might change?

From the perspective of a beginner wanting to try out this support - the hardest part in getting it working was setting this setting.

@cosmicexplorer
Copy link

cosmicexplorer commented Feb 18, 2020

the hardest part in getting it working was setting this setting.

I'll corroborate that -- I failed multiple times to remember how to do so in demonstrating the pants support to others.

@olafurpg
Copy link
Member

It's currently unclear if the pantsTargets setting will stay and it's also unclear what minimum Pants version will be required. I'm actively working on some changes that I'm hoping to have ready in the next couple weeks after which I'm optimistic I'll know better how the final integration will look like.

In the meantime, I would prefer to wait with advertising the Pants integration by making it visible in the VS Code configuration UI. Does that make sense?

@murph
Copy link
Author

murph commented Feb 18, 2020

I can't say I really agree - I don't see the harm in making it easier to configure an early plugin, especially as it only ever matters to users already using Pants for their build.

However, happy to respect your decision here. Thanks for working on this, it has already made me much more productive.

@murph murph closed this Feb 18, 2020
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
…rn/types/jest-26.0.17

Bump @types/jest from 26.0.16 to 26.0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants