use properties and environment when fetching metals #1498
Conversation
| }: FetchMetalsOptions): Promise<PackedChildPromise> { | ||
| const serverDependency = calcServerDependency(serverVersion); | ||
|
|
||
| const fetchProperties = serverProperties.filter( |
There was a problem hiding this comment.
I would just warn here, since we do debug metals sometimes and that requires setting debug settings.
Alternatively we could check if it's set to quiet=y.
There was a problem hiding this comment.
I restored that filter call from v1.29.0, but I'm not familiar with why it was there to being with.
To make sure I understand, are you asking to emit a warning message if -agentlib is present indicating that it isn't being passed to Coursier?
There was a problem hiding this comment.
Ach right, my bad. I forgot it was just for coursier, I assumed too much 😓 It's fine as it is, thanks!
| }: FetchMetalsOptions): Promise<PackedChildPromise> { | ||
| const serverDependency = calcServerDependency(serverVersion); | ||
|
|
||
| const fetchProperties = serverProperties.filter( |
There was a problem hiding this comment.
Ach right, my bad. I forgot it was just for coursier, I assumed too much 😓 It's fine as it is, thanks!
Fixes #1497