fix: workaround for empty completion list + isIncomplete = true
#1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dos65
force-pushed
the
fix_empty_incomplete_completions_req
branch
from
c685a46 to
1de2d86
Compare
If Vscode receives emptuy completion list it ignores `isIncomplete` field. Fixes: scalameta/metals#4756 Vscode issue: microsoft/vscode#155738
dos65
force-pushed
the
fix_empty_incomplete_completions_req
branch
from
1de2d86 to
040fa7d
Compare
tgodzik
added a commit
to tgodzik/metals-vscode
that referenced
this pull request
Jan 2, 2023
…calameta#1278) This reverts commit 5060b26. Unfortunately it seems that the message is rendered and we need a different workaround here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If VScode receives empty completion list it ignores
isIncompletefield.Fixes: scalameta/metals#4756
VScode issue: microsoft/vscode#155738