This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
Add mirror env variable when set by the user #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpodsiad
approved these changes
Feb 24, 2022
| @@ -17,6 +17,7 @@ export function detectLaunchConfigurationChanges( | |||
| "serverProperties", | |||
| "javaHome", | |||
| "customRepositories", | |||
| "coursierMirror", | |||
There was a problem hiding this comment.
Can we extract these keys as constants and use them in vscode?
There was a problem hiding this comment.
In a couple of places yes, but unfortunately not in package.json which would be most useful
There was a problem hiding this comment.
That's true, but at least we can reduce 3 possible sources of errors (config options names) to just 2
ckipp01
approved these changes
Feb 24, 2022
kpodsiad
reviewed
Feb 24, 2022
src/interfaces/UserConfiguration.ts
Outdated
| * | ||
| * - https://scalameta.org/metals/docs/integrations/new-editor#metals-user-configuration | ||
| */ | ||
| export const UserConfiguration = { |
There was a problem hiding this comment.
I think you can use enum, with it exporting type shouldn't be necessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be found https://github.com/coursier/coursier/blob/master/modules/paths/src/main/java/coursier/paths/Mirror.java#L26
Tested it out and seems to work (URLs go replaced by my string)
Will create VS Code PR soon.