chore: update node-fetch

[kpodsiad]

There is one change in the source code.

"@types/node-fetch" has been deprecated - This is a stub types definition. node-fetch provides its own type definitions, so you do not need this installed.

[kpodsiad]

I wanted to write some tests but they're failing because jest cannot consume the newest node-fetch:

node-fetch was converted to be a ESM only package in version 3.0.0-beta.10. node-fetch is an ESM-only module - you are not able to import it with require.

@gabro is this an issue? Will this PR and ESM only thing affect metals-vscode and metals-coc? I'm not an expert in commonjs/esm modules stuff.

[gabro]

It should be ok since typescript should take care of it, but in case it generates issues we can change the build target to esm as well.

Unfortunately I'm not uber-expert of ESM neither, so I recommend trying locally that the applications using this library still work.

[ckipp01]

Also heads up that coc-metals has been lagging behind for a while, mainly because I just haven't been updating it or really working on it anymore due to nvim-metals. So don't let that hinder this at all or I wouldn't worry too much about ensuring it works with coc-metals

[tanishiking]

I did some study about ESM, we have three choices. My conclusion: stay v2

1) Wait for VSCode (Electron) to support ESM

• Basically, we should be able to upgrade to pure ESM packages by following the instruction here
  • for more details: see https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c and https://stackoverflow.com/questions/61305578/what-typescript-configuration-produces-output-closest-to-node-js-14-capabilities
• However, VSCode has not yet supported consuming ESM (because Electron does not). So we can't use the v3 version of node-fetch with the instruction 😢
  • Enable consuming of ES modules in extensions microsoft/vscode#130367
  • Support Node's ES Modules electron/electron#21457

2) Wait TypeScript to stabilize "module": "node12" (and dynamic loading pure ESM package (I mean, node-fetch))

• "module": "node12" enables TypeScript to treat dynamic import as ESM
• And we'll be able to dynamic import node-fetch v3 like this
• However, "module": "node12" is still an experimental feature, and I don't want to use it until TS stabilize it :)
• see: TypeScript: Documentation - Experimental Support for ECMAScript Modules in Node.js

3) Stay in node-fetch v2 until 1 or 2 is ready (My recommendation for now)

As node-fetch says

You can also stay with the v2 branch - We will keep updating v2 with bug/security issues. But not so much with new features...
node-fetch/node-fetch#1279 (comment)

There's no rush to upgrade node-fetch to v3, just chill and wait for the upstream improvements :)

[tanishiking]

Opened a PR dependabot not to upgrade node-fetch to v3 #434

[kpodsiad]

Thanks for the analysis @tanishiking, I was never brave enough to do such thing and deep dive into JS modules worlds :D

I think we can close this PR.