Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just use 17 (no need for zulu etc.) #542

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Just use 17 (no need for zulu etc.) #542

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03d70ab
Test on Java 17
Aug 6, 2021
2a38dc9
Test on Java 17
Aug 6, 2021
ebf8b88
Use add build.properties (with sbt 1.5.5) to sbt-mdoc/basic test
Aug 6, 2021
f6fcb36
Just use 17 (no need for zulu etc.)
Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: ['[email protected]', '[email protected]', '[email protected]']
java: [[email protected], [email protected], 17]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better that we leave zulu here so that we know what is being used. We might want to change to adopt later along the line when it's released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to change to adopt later along the line when it's released

If we have it as 17, olafurpg/setup-scala (transitively jabba) will do that for us automatically.
But if we keep it as zulu..., a human will have to remember to come later and make the change -- That's not worth it, IMHO. Most likely, what will happen, is that we will forget about this and will be testing against a pre-release version of Java 17 for years to come 😸

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach, ok cool. Didn't know that, thanks!

command:
- "'++2.11.12 test'"
# Test legacy Scala versions, where reporting API changed
Expand Down