Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JS modifier on all Scala 2 versions #503

Merged
merged 1 commit into from
May 15, 2021

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented May 15, 2021

Closes #499

Had to change one test as on 2.11 the compiler wants an explicit annotation in the lambda.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit e51baaf into main May 15, 2021
@keynmol keynmol deleted the js-tests-all-scala-2-versions branch May 15, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run JS modifier tests for 2.13 (and 2.11?)
2 participants