Bump to 2.13.4 and make sure CI is testing correct cross versions #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like most errors come from line changes, so should be enough to just adjust them. |
ckipp01
force-pushed
the
2134
branch
5 times, most recently
from
f118403 to
366e1f3
Compare
ckipp01
commented
Nov 29, 2020
| |error: dep-error.md:3:13: Error downloading org.scalameta:mmunit_2.13:2.3.4 | ||
| |<redacted user.home> | ||
| | not found: https://repo1.maven.org/maven2/org/scalameta/mmunit_2.13/2.3.4/mmunit_2.13-2.3.4.pom | ||
| |import $dep.`org.scalameta::mmunit:2.3.4`, $dep.`org.scalameta:foobar:1.2.1` | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| |error: dep-error.md:4:13: Error downloading org.scalameta:not-exists_2.13.4:2.3.4 |
There was a problem hiding this comment.
I'm not 100% sure why the order flips here between 2.13.2 and 2.13.4 🤔
There was a problem hiding this comment.
I think it's ok, the order should not matter here.
tgodzik
approved these changes
Nov 29, 2020
| |error: dep-error.md:3:13: Error downloading org.scalameta:mmunit_2.13:2.3.4 | ||
| |<redacted user.home> | ||
| | not found: https://repo1.maven.org/maven2/org/scalameta/mmunit_2.13/2.3.4/mmunit_2.13-2.3.4.pom | ||
| |import $dep.`org.scalameta::mmunit:2.3.4`, $dep.`org.scalameta:foobar:1.2.1` | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| |error: dep-error.md:4:13: Error downloading org.scalameta:not-exists_2.13.4:2.3.4 |
There was a problem hiding this comment.
I think it's ok, the order should not matter here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.