Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate withCoproductInstance name #500

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Apr 11, 2024

TODO:

  • withSealedSubtypeHandled and withEnumCaseHandled as a replacement for withCoproductInstance
  • similarly for withCoproductInstancePartial
  • deprecate withCoproductInstance and withCoproductInstancePartial
  • update documentation
    • replace withCoproductInstance with withSealedSubtypeHandled
    • mention withEnumCaseHandled as alternative
    • explain difference between withSealedSubtypeHandled and .matching in path DSL
  • use withEnumCaseHandled in tests

…for withCoproductInstance, deprecate the last one (same for partials)
@MateuszKubuszok MateuszKubuszok added this to the 1.0.0-RC milestone Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.30%. Comparing base (b71778f) to head (c07e3f3).
Report is 1 commits behind head on master.

Files Patch % Lines
...etime/dsl/PartialTransformerDefinitionMacros.scala 0.00% 1 Missing ⚠️
...compiletime/dsl/PartialTransformerIntoMacros.scala 50.00% 1 Missing ⚠️
...etime/dsl/PartialTransformerDefinitionMacros.scala 75.00% 1 Missing ⚠️
.../compiletime/dsl/TransformerDefinitionMacros.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   90.43%   90.30%   -0.13%     
==========================================
  Files         129      128       -1     
  Lines        5059     5064       +5     
  Branches      445      445              
==========================================
- Hits         4575     4573       -2     
- Misses        484      491       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok changed the title Deprecate withCoproductInstance Deprecate withCoproductInstance name Apr 11, 2024
…ain the difference between withSealedSubtypeHandled and withFieldComputed with matching path
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review April 12, 2024 10:27
@MateuszKubuszok MateuszKubuszok merged commit cdf2eaf into master Apr 12, 2024
21 of 23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the deprecate-coproduct-instance branch April 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant