-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bean and error message improvements #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 90.02% 91.84% +1.81%
==========================================
Files 125 100 -25
Lines 4663 2354 -2309
Branches 393 228 -165
==========================================
- Hits 4198 2162 -2036
+ Misses 465 192 -273 ☔ View full report in Codecov by Sentry. |
MateuszKubuszok
force-pushed
the
bean-support-improvements
branch
from
March 25, 2024 19:20
88ddb2c
to
b45ace3
Compare
…issingFieldTransformer error, removed unused CantFindValueClassMember
…atching ambiguities
…t used, improving setter handling
MateuszKubuszok
force-pushed
the
bean-support-improvements
branch
from
March 25, 2024 19:21
b45ace3
to
f5dc5a9
Compare
…added MissingFieldTransformer error, removed unused CantFindValueClassMember
…1 field that can match them
MateuszKubuszok
force-pushed
the
bean-support-improvements
branch
from
March 25, 2024 22:33
1e22ca2
to
0771dc9
Compare
…ducts, java beans, sealed traits and Scala 3 enums, fix mismatch in constructor's var treatment between Scala 2 and 3
…o reason, add returnedType to ConstructorSetter
7 tasks
MateuszKubuszok
force-pushed
the
bean-support-improvements
branch
from
March 29, 2024 09:45
dabfbc9
to
a24f252
Compare
MateuszKubuszok
added
the
breaking change
Change resulting in compilation errors of code that used to be considered correct, or linking errors
label
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Change resulting in compilation errors of code that used to be considered correct, or linking errors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is housekeeping things related to error messages:
.enableMethodAccessors
.enableInhertedAccessors
setName(..): Unit
as setters and allowing e.g.setName(...): this.type
setters as opt-inTODO:
there should be NO ambiguity if user provided explicit matching via overridethat came out so difficult do do it right and it generated so many weird cases that for now I decided to now deal with it at all - any ambiguity -> error or custom name comparatorthat includesthis came out to be impossible, so instead w provided a better error messagewithFieldRenamed
enableNonUnitSetters
var
s in constructor Scala 2 code treates as accessors and Scala 3 as constructor vals, now both are treating them as constructor vals when it comes to extracting values