Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all Cats instances with cats, add Alternative instance for partial.Result and PartialTransformer, change instances name to something which won't change as often #465

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Feb 22, 2024

TODO:

  • add tests for partial.Result.orElse
  • create Scaladoc for orElse
  • update mkdocs for Cats instances
  • perhaps use arrow name instead of category in cats.arrow instances names

…tial.Result and PartialTransformer, change instances name to something which won't change as often
@MateuszKubuszok MateuszKubuszok added this to the 1.0.0-RC milestone Feb 22, 2024
@MateuszKubuszok MateuszKubuszok added the breaking change Change resulting in compilation errors of code that used to be considered correct, or linking errors label Feb 22, 2024
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review March 5, 2024 13:01
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (9c0fc38) to head (1e2a963).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   85.77%   90.05%   +4.28%     
==========================================
  Files         124      124              
  Lines        5342     4576     -766     
  Branches      213      387     +174     
==========================================
- Hits         4582     4121     -461     
+ Misses        760      455     -305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok changed the title Prefix all cats instances with cats, add Alternative instance for partial.Result and PartialTransformer, change instances name to something which won't change as often Prefix all Cats instances with cats, add Alternative instance for partial.Result and PartialTransformer, change instances name to something which won't change as often Mar 13, 2024
@MateuszKubuszok MateuszKubuszok merged commit df35686 into master Mar 22, 2024
23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the cats-alternative branch March 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change resulting in compilation errors of code that used to be considered correct, or linking errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant