Implement NoInfer linter. #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add docs - assert: instead of scalafix: in testkit - Support empty string id in LintCategory - Update Rule docstring to be cleaner.
gabro
reviewed
Sep 7, 2017
| @@ -95,7 +96,7 @@ abstract class SemanticRuleSuite( | |||
| val key = lintMessages.head.category.key(rule.name) | |||
| val explanation = | |||
| s"""|To fix this problem, suffix the culprit lines with | |||
| | // scalafix: $key | |||
| | // assert: $key | |||
There was a problem hiding this comment.
how does the // assert comment work?
There was a problem hiding this comment.
You can assert which linter message is reported at which specfic lines https://github.com/scalacenter/scalafix/blob/master/scalafix-tests/input/src/main/scala/test/NoInfer.scala#L7
The test fails if
- the linter category doesn't match,
- a message is not reported on that line
- a message is reported at a line without an assert
There was a problem hiding this comment.
Nice! This is only for testkit right?
There was a problem hiding this comment.
Yes, this is only testkit. Escape hatches for users are yet unimplemented #241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first scalafix linter rule. There are still a few rough corners around how to display carets around synthetics but the api is already usable. It was a great exercise to implement this linter since I found a few necessary parts missing in testkit to make the experience nice.