testkit: build against ScalaTest 3.2 #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
rip-scalatest-30
branch
from
853bccc to
c903c63
Compare
bjaglin
force-pushed
the
rip-scalatest-30
branch
from
c903c63 to
5c81776
Compare
bjaglin
commented
Apr 16, 2023
| @@ -211,7 +207,7 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys { | |||
| // don't publish scala 3 artifacts for now | |||
| publish / skip := (if ((publish / skip).value) true | |||
| else scalaBinaryVersion.value == "3"), | |||
| versionPolicyIntention := Compatibility.BinaryCompatible, | |||
| versionPolicyIntention := Compatibility.None, | |||
There was a problem hiding this comment.
I want to merge this just before tagging 0.11.0, otherwise other breaking changes that we still want to minimize will go undetected
bjaglin
force-pushed
the
rip-scalatest-30
branch
3 times, most recently
from
86388f9 to
da9835e
Compare
This is a source-breaking change for testkit users that were relying on the ScalaTest 3.0 package hierarchy, deprecated 3 years ago in 3.1 and removed in 3.2 (despite no major bump). Scalafix rules were made available to ease that transition, see https://github.com/scalatest/autofix/tree/master.
This was referenced Jun 3, 2023
bjaglin
added a commit
to scalacenter/scalafix.g8
that referenced
this pull request
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a source-breaking change for testkit users that were relying on the ScalaTest 3.0 package hierarchy, deprecated 3 years ago in 3.1 and removed in 3.2 (despite no major bump).
Scalafix rules were made available to ease that transition, see https://github.com/scalatest/autofix/tree/master.
Closes #1662.