Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose scalafix 2.13 patch version in scalafix-interfaces #1150

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Jun 4, 2020

Follow-up of #1118

@bjaglin bjaglin marked this pull request as ready for review June 4, 2020 11:01
@bjaglin bjaglin requested a review from mlachkar June 4, 2020 11:01
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bjaglin
Copy link
Collaborator Author

bjaglin commented Jun 4, 2020

I wonder if these scala methods are actually used/useful, as you need scalafix-cli to get an implementation for that interface, but to load that scalafix-cli, you must have looked up the scala versions from scalafix-interfaces.properties. Is there another scenario I am missing?

@olafurpg
Copy link
Contributor

olafurpg commented Jun 4, 2020

It's a good point. Maybe not 🤔 I feel like the architecture would make more sense if we have a bit of glue code implemented in Java as part of scalafix-interfaces that provides

  • coursier resolution/fetch
  • classloading of the correct scalafix-cli

@bjaglin
Copy link
Collaborator Author

bjaglin commented Jun 4, 2020

Agreed, that would be a good first step to push up some stuff currently in sbt-scalafix (and mill-scalafix, etc), as also discussed in scalacenter/sbt-scalafix#121 (review). I'll file an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants