Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Use proper rt.jar if it exists #2450

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 25, 2024

Previously, we would automatically generate our own rt.jar from the Bloop's JDK, however this would put all the current JDK classes into that jar, which means some things might compile while they should not. This limitation is present both in Mill and sbt. We would only fail on added methods.

Now, we try to locate rt.jar if javaHome is set, so we can use it explicitely.

Previously, we would automatically generate our own rt.jar from the Bloop's JDK, however this would put all the current JDK classes into that jar, which means some things might compile while they should not. This limitation is present both in Mill and sbt. We would only fail on added methods.

Now, we try to locate rt.jar if javaHome is set, so we can use it explicitely.
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking

backend/src/main/scala/bloop/Compiler.scala Outdated Show resolved Hide resolved
backend/src/main/scala/bloop/Compiler.scala Outdated Show resolved Hide resolved
@tgodzik tgodzik merged commit 34c545b into scalacenter:main Sep 26, 2024
16 of 17 checks passed
@tgodzik tgodzik deleted the rtjarring branch September 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants